chore: reenable integration tests #470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=========================================
+ Coverage 73.52% 73.62% +0.1%
=========================================
Files 44 44
Lines 2047 2059 +12
Branches 330 332 +2
=========================================
+ Hits 1505 1516 +11
- Misses 542 543 +1
Continue to review full report at Codecov.
|
| @@ -33,7 +33,7 @@ | |||
| "lint": "tslint --project . && eslint test/", | |||
| "test": "nyc mocha", | |||
| "report-coverage": "nyc report --reporter=json && codecov -f coverage/*.json", | |||
| "integration": "integration-loader && integration all", | |||
| "integration": "integration-loader && integration all -- --exit", | |||
There was a problem hiding this comment.
What is --exit? I don't see it in https://github.com/interledgerjs/five-bells-integration-test/blob/master/src/bin/integration.
There was a problem hiding this comment.
As there are unterminated listeners lingering in tests/tested components (STREAM and possible Connector), Mocha 4 doesnt automatically exit the tests (mochajs/mocha#3044)
Adding the -- --exit passes the exit flag to mocha and allows the tests to exit correctly after finished running
There was a problem hiding this comment.
Unterminated listeners seems like a bug that should be fixed, not sidestepped, but this is an alright stopgap.
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 73.62% 73.62%
=======================================
Files 44 44
Lines 2059 2059
Branches 332 332
=======================================
Hits 1516 1516
Misses 543 543 Continue to review full report at Codecov.
|
Re enable the integration tests now that the integration tests have been moved to use ILPv4 with STREAM